Push to PRD #256
Merged
Push to PRD #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bitbeckers
commented
Jan 30, 2025
bitbeckers
commented
- Updated metadata validation
- Updates sales table
- Prepare for fixing hypercert IDs in sales table
- Update sales table values for curreny amounts, fees and other missing values
Replaces local implementation of metadata validation with SDK version
remove unused metadata zod validator and update coverage thresholds
…ation Update metadata validation
…s columns to sales table - Introduced new columns to the sales table to store currency amounts, fee amounts as an array, and fee recipients as an array.
…tails - Updated `parseTakerBidEvent` to include parsing of currency amount, fee amounts, and fee recipients. - Refactored transaction log handling to support HypercertExchange and ERC20 ABI. - Expanded `TakerBid` schema in `storeTakerBid` to accommodate new fields for currency and fees.
- this script will retroactively update existing rows in the sales table of supabase to contain fee_amounts, fee_recipients and currency_amount - it will also update any hypercert_id's that erronously ended up with an 'undefined' for the token ID
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
@bitbeckers One deleted zod file there, haven't touched that. Any idea if that's an issue? EDIT: Nevermind, I see that metadata parsing has been updated altogether. Do I have to re-review this? I suppose that's been done already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.