Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warp deploy configs reader functions #521

Merged
merged 29 commits into from
Jan 27, 2025

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Jan 24, 2025

Description

Add Warp Deploy Config reader functions getWarpDeployConfigs() and getWarpDeployConfig() as well DRY out logic that is shared with getWarpRoute()

Backward compatibility

Yes

Testing

Unit tests

Fixes: hyperlane-xyz/hyperlane-monorepo#5261

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: eefadd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you're on the right track

src/registry/FileSystemRegistry.ts Outdated Show resolved Hide resolved
src/registry/FileSystemRegistry.ts Outdated Show resolved Hide resolved
src/registry/IRegistry.ts Outdated Show resolved Hide resolved
src/registry/PartialRegistry.ts Outdated Show resolved Hide resolved
src/registry/PartialRegistry.ts Outdated Show resolved Hide resolved
src/registry/SynchronousRegistry.ts Outdated Show resolved Hide resolved
src/registry/SynchronousRegistry.ts Show resolved Hide resolved
test/unit/warp-routes.test.ts Outdated Show resolved Hide resolved
test/unit/warp-routes.test.ts Outdated Show resolved Hide resolved
@ltyu ltyu changed the title feat: warp speed warp configs reader feat: Add warp deploy configs reader functions Jan 24, 2025
src/registry/FileSystemRegistry.ts Outdated Show resolved Hide resolved
@ltyu ltyu enabled auto-merge January 27, 2025 15:04
@ltyu ltyu added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit a589dad Jan 27, 2025
6 checks passed
@ltyu ltyu deleted the ltyu/warp-speed-warpConfigs-reader branch January 27, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warp Deploy Config fetching via IRegistry
2 participants