Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-connector-besu): add RunTransactionV1Exchange to share receipt data #3642

Merged

Conversation

RafaelAPB
Copy link
Contributor

@RafaelAPB RafaelAPB commented Nov 15, 2024

Peter's change(s): updated the spellcheck configuration to ignore expressions
that we know are correct but aren't present in the default dicitonary of the
tool.

Authored-by: Bruno Mateus [email protected]
Co-authored-by: Rafael Belchior [email protected]
Co-authored-by: Peter Somogyvari [email protected]

Signed-off-by: Rafael Belchior [email protected]
Signed-off-by: Peter Somogyvari [email protected]

#3641 depends on this PR

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelAPB RafaelAPB force-pushed the satp-dev-fixup-connector-besu branch 2 times, most recently from 54af23f to 7d84a17 Compare November 27, 2024 17:45
@petermetz
Copy link
Contributor

@RafaelAPB I'll rebase this and fix the build errors + lint errors

…eceipt data

Peter's change(s): updated the spellcheck configuration to ignore expressions
that we know are correct but aren't present in  the default dicitonary of the
tool.

Authored-by: Bruno Mateus [email protected]
Co-authored-by: Rafael Belchior [email protected]
Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Rafael Belchior <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the satp-dev-fixup-connector-besu branch from 7d84a17 to 46d9dc8 Compare November 30, 2024 21:33
@petermetz petermetz requested a review from takeutak as a code owner November 30, 2024 21:33
@petermetz
Copy link
Contributor

@RafaelAPB I fixed the spell check errors, the CI should be passing now.

@petermetz petermetz merged commit 3097c84 into hyperledger-cacti:main Nov 30, 2024
136 of 139 checks passed
@petermetz petermetz deleted the satp-dev-fixup-connector-besu branch November 30, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants