Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Interoperation NodeJS SDK reference #3648

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

PR Summary
Commit f37495c renamed besu/interoperation-node-sdk/README.md to be besu/node/README.md. This PR adjusts sources to changes.

@emmanuel-ferdman emmanuel-ferdman changed the title docs: update Besu Interoperation NodeJS SDK docs: update Besu Interoperation NodeJS SDK reference Nov 21, 2024
@emmanuel-ferdman emmanuel-ferdman changed the title docs: update Besu Interoperation NodeJS SDK reference docs: update Interoperation NodeJS SDK reference Nov 21, 2024
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuel-ferdman LGTM, thank you very much for the contribution!

@jagpreetsinghsasan
Copy link
Contributor

LGTM

@petermetz petermetz requested a review from takeutak as a code owner November 30, 2024 21:58
@petermetz petermetz merged commit 5b68592 into hyperledger-cacti:main Nov 30, 2024
133 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants