-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): fix type exports in packages/cactus-common #3649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruzell22 Thank you! For your changes to be version controlled you cannot change index.js, you must change index.ts (which is the one that gets compiled to index.js)
ac4f10f
to
ddbe5b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've re-run failed yarn codegen check to see if it's caused by the PR or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruzell22 LGTM, thank you for the updates!
Primary Changes --------------- 1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore paths in get-all-tgz-path.ts file 2. Added the log-level.ts for the missing exports detected by attw -f json 3. Added exports in public-api.ts from log-level.ts Fixes: hyperledger-cacti#3635 Signed-off-by: ruzell22 <[email protected]>
Commit to be reviewed
ci(github): fix type exports in packages/cactus-common
Fixes: #3635
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.