Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix type exports in packages/cactus-common #3649

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

ruzell22
Copy link
Contributor

@ruzell22 ruzell22 commented Nov 21, 2024

Commit to be reviewed


ci(github): fix type exports in packages/cactus-common

Primary Changes
---------------
1. Removed packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore 
paths in get-all-tgz-path.ts file
2. Added the log-level.ts for the missing exports detected by attw -f json
3. Added exports in public-api.ts from log-level.ts

Fixes: #3635

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@ruzell22
Copy link
Contributor Author

ruzell22 commented Nov 21, 2024

Before fix:
image
adding -f json to attw command, it shows which file and which problem with export it is having.

After fix:
image
yarn run custom-checks and attw with and without -f json flag are all passing

EDIT:

I made changes to index.js and index.d.ts, however, it is not being added by git add -A before committing and pushing the code.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 Thank you! For your changes to be version controlled you cannot change index.js, you must change index.ts (which is the one that gets compiled to index.js)

@ruzell22 ruzell22 force-pushed the issue3635 branch 5 times, most recently from ac4f10f to ddbe5b2 Compare November 22, 2024 07:24
@ruzell22 ruzell22 requested a review from petermetz November 22, 2024 08:15
Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've re-run failed yarn codegen check to see if it's caused by the PR or not

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 LGTM, thank you for the updates!

Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the log-level.ts for the missing exports detected by attw -f json
3. Added exports in public-api.ts from log-level.ts

Fixes: hyperledger-cacti#3635

Signed-off-by: ruzell22 <[email protected]>
@petermetz petermetz merged commit 1c49527 into hyperledger-cacti:main Dec 1, 2024
133 of 137 checks passed
@petermetz petermetz deleted the issue3635 branch December 1, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): fix type exports in packages/cactus-common
3 participants