Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): publish v2.1.0 #3664

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore(release): publish v2.1.0 #3664

merged 1 commit into from
Dec 2, 2024

Conversation

petermetz
Copy link
Contributor

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz
Copy link
Contributor Author

@hyperledger-cacti/cacti-maintainers bump

@sandeepnRES
Copy link
Contributor

@petermetz Hey, is something wrong with mergefreeze? On the site it shows this PR is unfrozen, but mergrefreeze status isn't passed.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz
Copy link
Contributor Author

@petermetz Hey, is something wrong with mergefreeze? On the site it shows this PR is unfrozen, but mergrefreeze status isn't passed.

@sandeepnRES Good catch, thank you for noticing! I went and investigated and turns out for some reason mergefreeze was removed from the list of required checks (settings -> branch protection rules). I've added it back and now it works as it should. Phew, I'm glad we noticed that before accidentally merging another PR (because then I'd have to re-do the entire release PR from scratch)

@petermetz petermetz self-assigned this Dec 2, 2024
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz merged commit dc140e6 into main Dec 2, 2024
128 of 138 checks passed
@petermetz petermetz deleted the release-v2.1.0 branch December 2, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants