Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(htlc-eth-besu-erc20): migrate get-status-endpoint test cases to Jest #3674

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Udhayakumari
Copy link
Contributor

test(htlc-eth-besu-erc20): migrate get-status-endpoint to Jest

Primary Changes:

packages/cactus-test-plugin-htlc-eth-besu-erc20/src/test/typescript /integration/plugin-htlc-eth-besu-erc20/get-status-endpoint.test.ts

Fixes: #3650

Signed-off-by: Udhayakumari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Udhayakumari LGTM, thank you for the contribution!

@petermetz
Copy link
Contributor

@Udhayakumari Sorry, I just saw that there's one mandatory check failing (the lint).

Error: yarn lint script produced version control side-effects: source files have been changed by it that are otherwise are under version control. This means (99% of the time) that you need to run the yarn lint script locally and then include the changes it makes in your own commit when submitting your pull request.

Please fix that and then we should be good to merge

@petermetz
Copy link
Contributor

@hyperledger-cacti/cacti-maintainers bump

@Udhayakumari Udhayakumari force-pushed the get-status-endpoint branch 2 times, most recently from 76032e5 to b327998 Compare December 11, 2024 04:11
@Udhayakumari
Copy link
Contributor Author

@Udhayakumari Sorry, I just saw that there's one mandatory check failing (the lint).

Error: yarn lint script produced version control side-effects: source files have been changed by it that are otherwise are under version control. This means (99% of the time) that you need to run the yarn lint script locally and then include the changes it makes in your own commit when submitting your pull request.

Please fix that and then we should be good to merge

Hi @petermetz, have done the changes as you mentioned. Please check and let me know. Thanks!

…Jest

Primary Changes:

packages/cactus-test-plugin-htlc-eth-besu-erc20/src/test/typescript
/integration/plugin-htlc-eth-besu-erc20/get-status-endpoint.test.ts

Fixes: hyperledger-cacti#3650

Signed-off-by: Udhayakumari <[email protected]>
@petermetz petermetz merged commit d317ba4 into hyperledger-cacti:main Dec 12, 2024
135 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(htlc-eth-besu-erc20): migrate get-status-endpoint test cases from Tape to Jest
3 participants