Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return error properly #743

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

return error properly #743

wants to merge 4 commits into from
+26 −23

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Jan 30, 2025 •
edited
Loading

This PR does the following:

  1. It reduces logging form Infof to Debugf;
  2. It fixes a bug that was preventing an error returned by the callback function to be propagated as expected.

@adecaro
Infof to Debugf
b227da5 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro adecaro self-assigned this Jan 30, 2025
@adecaro
return missing error
ea542db 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
log error
bd5d169 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro
log Stop call
3a84cc8 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro adecaro changed the title Infof to Debugf return error properly Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrosfilios alexandrosfilios Awaiting requested review from alexandrosfilios

Assignees

@adecaro adecaro

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adecaro