Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 9 for max blobs when sizing BlobCache #8222

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Feb 3, 2025

EIP-7691 increases max blobs to 9 in Prague

Increase memory impact:

(6 * 32 * 3) -> (9 * 32 * 3)
576 blobs -> 864 blobs
73.7MB -> 110.6MB

Part of #7982

@siladu siladu added the Prague label Feb 3, 2025
@siladu siladu requested a review from jflo February 3, 2025 06:43
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be sourced from protocol schedule since we can now configure it in the genesis file.

Doing that in another issue/pr is fine.

@siladu
Copy link
Contributor Author

siladu commented Feb 4, 2025

Should be sourced from protocol schedule since we can now configure it in the genesis file.

@jflo Agree, I've intentionally left that for now as I think it needs some performance analysis/planning otherwise we could create a performance issue via the config.

This is discussed on the parent issue: #7982 which I will reword and re-add to the backlog now that we've done the necessaries for Pectra.

TL;DR - we could size according to the expected max (e.g. 128 blobs) and then hopefully not have to touch this again. Dynamic from config might be OK too, but we should probably cap it.

@siladu siladu enabled auto-merge (squash) February 4, 2025 00:15
@siladu siladu merged commit cb5c223 into hyperledger:main Feb 4, 2025
43 checks passed
@siladu siladu deleted the blob-cache-size-prague branch February 4, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants