Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial client go sdk prototype #452
Add initial client go sdk prototype #452
Changes from all commits
f95c5e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you assume we surface pdo crypto via cgo? As discussed in #412, i thought conceptually bridging at a higher-level (for arguments discussed there). The devil is in the details and what i propose might not work. However, i feel we should make a conscious decision on this interface. Right now it seems to me we end up making an implicit decision while not necessarily have considered the implication (maybe you did, but then i think we should reflect it in #412 and also resolve it there?)
To some extent it also seems to related on what exactly the semantics is of the "Transaction Crypto Library" boxes in mural?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be worth "outsourcing" this in a separate function as a simply cmd-line utility wrapper would be exactly the transform you would need in the peer cli (i.e., only a single and simple implementation and also a simplification of the peer cli script ...