Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to SGX SDK 2.12 and mention also Ubuntu 20.04 #509

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

g2flyer
Copy link
Contributor

@g2flyer g2flyer commented Dec 23, 2020

What this PR does / why we need it:

Make sure for release that we support latest SGX version; also enables us to provide support for Ubuntu 20.04 (see notes in README.md for some small config.override.mk change needed.)

Notes:

  • It still should work on a host having older SGX SDK, e.g., 2.11, just not on Ubuntu 20.04. So not hurry to upgrade your various test machines.
  • there is also a newer version of sgxssl ( lin2.11_1.1.1.g vs currently used lin2.10_1.1.1.g). As this version changed (pretty much undocumented short of code) pthread stuff and breaks pdo crypto, i didn't bump that version.

Which issue(s) this PR fixes:

Next iteration of #411

Special notes for your reviewer:

Does this PR introduce a user-facing changes and/or breaks backward compatability?:

@g2flyer g2flyer requested a review from a team December 23, 2020 00:57
@g2flyer g2flyer force-pushed the msteiner.sgx-2.12+ubuntu-20.04 branch from e11fefd to 1d45f10 Compare December 25, 2020 17:54
@g2flyer g2flyer mentioned this pull request Dec 28, 2020
Copy link
Contributor

@bvavala bvavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg.
Importantly, travis/docker tests with the 2.12 SDK, but locally the 2.10 SDK still works.

@bvavala bvavala merged commit f669d16 into hyperledger:master Dec 28, 2020
@g2flyer g2flyer deleted the msteiner.sgx-2.12+ubuntu-20.04 branch December 28, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants