Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making mock_ecc build and run successfully #518

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Making mock_ecc build and run successfully #518

merged 1 commit into from
Jan 13, 2021

Conversation

bvavala
Copy link
Contributor

@bvavala bvavala commented Jan 1, 2021

(self-explanatory)

Addresses #513 , and maintains (or adds) refactoring tasks in #502 .

Signed-off-by: Bruno Vavala [email protected]

@bvavala bvavala requested a review from a team January 1, 2021 11:00
@bvavala bvavala added this to the MVP FPC 1.0 (aka FPC Lite) milestone Jan 1, 2021
g2flyer
g2flyer approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@g2flyer g2flyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works fine (at least after i realized that maybe mock doesn't mesh well with HW mode and rebuilt everything with SIM ... :-))

mbrandenburger
mbrandenburger approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@mbrandenburger mbrandenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bruno! This looks good

@mbrandenburger mbrandenburger merged commit 1ae121e into hyperledger:master Jan 13, 2021
@mbrandenburger mbrandenburger mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandenburger mbrandenburger mbrandenburger approved these changes

@g2flyer g2flyer g2flyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP FPC 1.0 (aka FPC Lite)
Development

Successfully merging this pull request may close these issues.
3 participants
@bvavala @g2flyer @mbrandenburger