feat: Mimicking getting data on github #924
Conversation
|
I think it is necessary to separate the files for each feature into folders on different platforms and consider their necessity. Is it too redundant, as many files (such as view files) are platform independent and only require passing different data and finding different elements on the page. |
|
Would it be more convenient to extract different file retrieval functions and page element retrieval functions from the index file in each functional folder and extract them to different files within that folder. Otherwise, when changing the component itself, files in two different platform folders will need to be modified simultaneously. |
Yes, that makes sense, the different platform functions that get elements and the functions that get data can be extracted, under each function folder, divided into github.ts and gitee.ts. |
|
I will revise and refactor this again. |
|
Due to the need for a major refactoring and numerous conflicts between the current PR and the latest version of the project that need to be resolved. Therefore, I am preparing to close this PR and start a new PR to work on. |
Yes. That's right. |
| export async function isDeveloperWithMeta() { | ||
| return pageDetect.isUserProfile() && (await metaStore.has(getDeveloperName())); | ||
| export async function isDeveloperWithMeta(platform: string) { | ||
| return pageDetect.isUserProfile() && (await metaStore.has(platform, getDeveloperName())); |
There was a problem hiding this comment.
PageDetect is a tool in the github-url-detection package used to detect the URL structure of the current Github page. For the Gitee platform, using it this way to determine if it is a developer profile page should be incorrect.Because Gitee and Github have different page structures and URL patterns. Similar methods to using github-url-detection to obtain information may not be effective when migrating to the Gitee platform. You can try it and see if it's like this.
There was a problem hiding this comment.
So I have mentioned several times before in some tasks involving Gitee, and suggested that you can do something about encapsulating the function methods for obtaining user names, project names, and other information on the Gitee platform based on URLs or page elements.
There was a problem hiding this comment.
When you have free time afterwards, you can make corresponding attempts. At the same time, it is also possible to learn more about the specific methods and techniques used in the project during this process.
There was a problem hiding this comment.
During this process, I will also do these things together.
There was a problem hiding this comment.
Thanks for pointing out my problem.I'll follow up on the project.😊
There was a problem hiding this comment.
Thanks for pointing out my problem.I'll follow up on the project.😊
Firstly, prioritize school exams. Wait until the exam is over.
|
It's best to establish a goal plan. Through time planning, we can better arrange things. Two time points, before the start and end of the next semester.
Of course, this plan is just a plan. Being able to complete it is the best. The time left should still be quite ample. |
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
In preparation for HyperCRX to adapt to Gitee platform, similar to Github platform to get data and so on, changed the relevant get data file.
Checklist
Others