Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExportAnnotations accessibility test #5940

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Nov 8, 2023

This fixes a failing test spotted while working on #5938

To simplify that PR, this one updates both @hypothesis/frontend-shared, which is what makes the test fail, and @hypothesis/frontend-testing, which introduces the tools to work around that failing test.

Fixes #5939

Supersedes #5922

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #5940 (4607e1b) into main (07b9710) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5940   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         257      257           
  Lines        9887     9887           
  Branches     2362     2362           
=======================================
  Hits         9832     9832           
  Misses         55       55           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@acelaya acelaya merged commit 1269a43 into main Nov 8, 2023
4 checks passed
@acelaya acelaya deleted the export-annotations-a11y-fix branch November 8, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate ExportAnnotations a11y test failing when using the new SelectNext with role="combobox"
2 participants