Include an option to use ruff as the linter #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcospri
commented
Nov 12, 2024
•
marcospri
commented
- Applied on LMS: Apply changes from the cookiecutter lms#6929
- Also applied to via over: Apply changes from cookiecutter: Migrate from pylint to ruff via#1498
marcospri
force-pushed
the
ruff-linter
branch
8 times, most recently
from
1c30ee0 to
e3dc1f5
Compare
marcospri
force-pushed
the
ruff-linter
branch
2 times, most recently
from
2e819db to
d2dcc6b
Compare
marcospri
changed the title
marcospri
force-pushed
the
ruff-linter
branch
3 times, most recently
from
9373e25 to
f9d53a7
Compare
marcospri
commented
Jan 2, 2025
| @@ -43,6 +43,10 @@ def remove_conditional_files(): | |||
| paths_to_remove.extend([".github/workflows/pypi.yml"]) | |||
| {% endif %} | |||
|
|
|||
| {% if cookiecutter.get("linter") == "ruff" %} | |||
There was a problem hiding this comment.
ruff config is more compact, no need for two files, remove the test one in case is generated.
_shared/project/pyproject.toml
Outdated
| @@ -77,7 +159,12 @@ show_missing = true | |||
| precision = 2 | |||
| fail_under = 100.00 | |||
| skip_covered = true | |||
| exclude_also = [ | |||
There was a problem hiding this comment.
Ignore this type of conditional from coverage.
| @@ -48,7 +52,13 @@ def delete(engine: Engine) -> None: | |||
| else: | |||
| pre_delete(engine) | |||
|
|
|||
| Base.metadata.drop_all(engine) | |||
| with engine.connect() as connection: | |||
| # Delete the DB "public" schema directly. | |||
There was a problem hiding this comment.
This is part of LMS, it seems to have worked for a while. Bringing it to other repos.
marcospri
commented
Jan 2, 2025
| "PLR2004", # Magic values, we mostly get it on HTTP status codes | ||
|
|
||
| # Disabled during the pylint migration, ideally we'll enable this after we are settled in ruff | ||
| "RET504", |
There was a problem hiding this comment.
Having these here allows to remove them from the template and apply to all projects.
This was referenced Jan 2, 2025
|
Rebased |
seanh
added a commit
that referenced
this pull request
Jan 10, 2025
This is extracted from #188 as a separate PR. This commit also adds includes for per-project overriding or extending of the coverage excludes: * If a project has a `.cookiecutter/includes/coverage/exclude_also` file that will _replace_ the cookiecutter's default `exclude_also`'s * If a project has a `.cookiecutter/includes/coverage/exclude_also/tail` file that will _extend_ the cookiecutter's default `exclude_also`'s Also fix a bug in `local_extensions.py`'s `include_exists(path)` function: don't crash if there's a _folder_ (rather than a file) at `path` (the code was catching the wrong exception class, looks like just a mistake).
seanh
added a commit
that referenced
this pull request
Jan 10, 2025
Extracted from #188 as a separate PR. > Type-checks the interior of functions without type annotations. https://mypy.readthedocs.io/en/stable/config_file.html#confval-check_untyped_defs
seanh
added a commit
that referenced
this pull request
Jan 10, 2025
Add a couple of includes for per-project customisation of which modules we tell mypy to ignore. This also tidies up the formatting of this section of pyproject.toml a little, which unfortunately will mean a change to every single project. This is extracted from #188 as a separate PR.
seanh
added a commit
that referenced
this pull request
Jan 10, 2025
Add a couple of includes for per-project customisation of which modules we tell mypy to ignore. This also tidies up the formatting of this section of pyproject.toml a little, which unfortunately will mean a change to every single project. This is extracted from #188 as a separate PR.
seanh
added a commit
that referenced
this pull request
Jan 10, 2025
Extracted from #188 as a separate PR.
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
This is extracted from #188 as a separate PR. This commit also adds includes for per-project overriding or extending of the coverage excludes: * If a project has a `.cookiecutter/includes/coverage/exclude_also` file that will _replace_ the cookiecutter's default `exclude_also`'s * If a project has a `.cookiecutter/includes/coverage/exclude_also/tail` file that will _extend_ the cookiecutter's default `exclude_also`'s Also fix a bug in `local_extensions.py`'s `include_exists(path)` function: don't crash if there's a _folder_ (rather than a file) at `path` (the code was catching the wrong exception class, looks like just a mistake).
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
This is extracted from #188 as a separate PR. This commit also adds includes for per-project overriding or extending of the coverage excludes: * If a project has a `.cookiecutter/includes/coverage/exclude_also` file that will _replace_ the cookiecutter's default `exclude_also`'s * If a project has a `.cookiecutter/includes/coverage/exclude_also/tail` file that will _extend_ the cookiecutter's default `exclude_also`'s Also fix a bug in `local_extensions.py`'s `include_exists(path)` function: don't crash if there's a _folder_ (rather than a file) at `path` (the code was catching the wrong exception class, looks like just a mistake).
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
Add a couple of includes for per-project customisation of which modules we tell mypy to ignore. This also tidies up the formatting of this section of pyproject.toml a little, which unfortunately will mean a change to every single project. This is extracted from #188 as a separate PR.
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
Add a couple of includes for per-project customisation of which modules we tell mypy to ignore. This also tidies up the formatting of this section of pyproject.toml a little, which unfortunately will mean a change to every single project. This is extracted from #188 as a separate PR.
seanh
added a commit
that referenced
this pull request
Jan 17, 2025
Extracted from #188 as a separate PR.
seanh
force-pushed
the
ruff-linter
branch
2 times, most recently
from
43f91b1 to
8f2f97d
Compare
seanh
changed the base branch from
main
to
move-setuptools-into-pyproject.toml
|
I've rebased this onto #201 |
|
Closing in favour of #196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.