Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate borderless prop from DataTable to Table #1354

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Nov 7, 2023

This was an overlook from #1289

Expose a borderless prop from DataTable that can be propagated to the Table component.

@acelaya acelaya requested a review from robertknight November 7, 2023 15:29
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1354 (ffd76c8) into main (a577d5a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head ffd76c8 differs from pull request most recent head 83c8ce1. Consider uploading reports for the commit 83c8ce1 to get more accurate results

@@            Coverage Diff            @@
##              main     #1354   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines          931       931           
  Branches       358       358           
=========================================
  Hits           931       931           
Files Coverage Δ
src/components/data/DataTable.tsx 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see comment about whether we should pass this prop explicitly rather than through the now-misnamed htmlAttributes.

@acelaya acelaya force-pushed the borderless-data-table branch from ffd76c8 to e8ab114 Compare November 8, 2023 14:40
@acelaya acelaya force-pushed the borderless-data-table branch from e8ab114 to 83c8ce1 Compare November 8, 2023 14:44
@acelaya acelaya merged commit e9b496c into main Nov 8, 2023
2 checks passed
@acelaya acelaya deleted the borderless-data-table branch November 8, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants