Do not render Popover children while closed #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Nov 22, 2024
| @@ -79,7 +79,7 @@ describe('Select', () => { | |||
| const toggleListbox = wrapper => getToggleButton(wrapper).simulate('click'); | |||
|
|
|||
| const isListboxClosed = wrapper => | |||
| wrapper.find('[role="listbox"]').prop('data-listbox-open') === false; | |||
| wrapper.find('Popover').prop('open') === false; | |||
There was a problem hiding this comment.
This was the only change needed to fix a bunch of failing Select tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1792 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 68 68
Lines 1220 1220
Branches 465 465
=========================================
Hits 1220 1220 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 22, 2024
robertknight
approved these changes
Nov 25, 2024
acelaya
force-pushed
the
popover-component
branch
from
3021966 to
8e767d5
Compare
acelaya
force-pushed
the
empty-closed-popover
branch
from
505c800 to
2f320de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1791
Make sure the
Popovercomponent renders its children only while it's open.This also removes the requirement to control this in the
Selectcomponent, while adding the same benefit for other places where we usePopover.