Export ListenerCollection from the main entry point #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 70 70
Lines 1303 1303
Branches 482 482
=========================================
Hits 1303 1303 ☔ View full report in Codecov by Sentry. |
robertknight
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM. I noted in Slack that there is now a built-in API for batch de-registration via addEventListener's signal option. This is still quite a new API however which we can't quite rely on yet (requires Safari >= 15). We can consider adopting it as a requirement some time next year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have similar
ListenerCollectionutilities in other projects, so exposing the one from this library so that we can remove a bit of duplicated code.