Upgrade python patch versions and drop 3.8

.cookiecutter/cookiecutter.json

@@ -11,7 +11,7 @@
     "package_name": "h_assets",
     "slug": "h-assets",
     "short_description": "Pyramid views for serving collections of compiled static assets (eg. bundles of JavaScript and CSS).",
-    "python_versions": "3.12.4, 3.11.9, 3.10.14, 3.9.19, 3.8.19",
+    "python_versions": "3.12.7, 3.11.10, 3.10.15, 3.9.20",
     "github_owner": "hypothesis",
     "copyright_holder": "Hypothesis",
     "visibility": "public",

.github/workflows/ci.yml

@@ -49,7 +49,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.12', '3.11', '3.10', '3.9', '3.8']
+        python-version: ['3.12', '3.11', '3.10', '3.9']
     name: Unit tests with Python ${{ matrix.python-version }}
     steps:
       - uses: actions/checkout@v3
@@ -87,7 +87,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.12', '3.11', '3.10', '3.9', '3.8']
+        python-version: ['3.12', '3.11', '3.10', '3.9']
     name: Functional tests with Python ${{ matrix.python-version }}
     steps:
       - uses: actions/checkout@v3

.python-version

@@ -1,5 +1,4 @@
-3.12.4
-3.11.9
-3.10.14
-3.9.19
-3.8.19
+3.12.7
+3.11.10
+3.10.15
+3.9.20

Makefile

@@ -53,15 +53,10 @@ $(call help,make test-py39,"run the unit tests in Python 3.9")
 test-py39: python
 	@pyenv exec tox -qe py39-tests
 
-.PHONY: test-py38
-$(call help,make test-py38,"run the unit tests in Python 3.8")
-test-py38: python
-	@pyenv exec tox -qe py38-tests
-
 .PHONY: coverage
 $(call help,make coverage,"run the tests and print the coverage report")
 coverage: python
-	@pyenv exec tox --parallel -qe 'tests,py{311,310,39,38}-tests,coverage'
+	@pyenv exec tox --parallel -qe 'tests,py{311,310,39}-tests,coverage'
 
 .PHONY: functests
 $(call help,make functests,"run the functional tests in Python 3.12")
@@ -83,16 +78,11 @@ $(call help,make functests-py39,"run the functional tests in Python 3.9")
 functests-py39: python
 	@pyenv exec tox -qe py39-functests
 
-.PHONY: functests-py38
-$(call help,make functests-py38,"run the functional tests in Python 3.8")
-functests-py38: python
-	@pyenv exec tox -qe py38-functests
-
 .PHONY: sure
 $(call help,make sure,"make sure that the formatting$(comma) linting and tests all pass")
 sure: python
 sure:
-	@pyenv exec tox --parallel -qe 'checkformatting,lint,typecheck,tests,py{311,310,39,38}-tests,coverage,functests,py{311,310,39,38}-functests'
+	@pyenv exec tox --parallel -qe 'checkformatting,lint,typecheck,tests,py{311,310,39}-tests,coverage,functests,py{311,310,39}-functests'
 
 .PHONY: template
 $(call help,make template,"update from the latest cookiecutter template")

README.md

@@ -1,6 +1,6 @@
 <a href="https://github.com/hypothesis/h-assets/actions/workflows/ci.yml?query=branch%3Amain"><img src="https://img.shields.io/github/actions/workflow/status/hypothesis/h-assets/ci.yml?branch=main"></a>
 <a href="https://pypi.org/project/h-assets"><img src="https://img.shields.io/pypi/v/h-assets"></a>
-<a><img src="https://img.shields.io/badge/python-3.12 | 3.11 | 3.10 | 3.9 | 3.8-success"></a>
+<a><img src="https://img.shields.io/badge/python-3.12 | 3.11 | 3.10 | 3.9-success"></a>
 <a href="https://github.com/hypothesis/h-assets/blob/main/LICENSE"><img src="https://img.shields.io/badge/license-BSD--2--Clause-success"></a>
 <a href="https://github.com/hypothesis/cookiecutters/tree/main/pypackage"><img src="https://img.shields.io/badge/cookiecutter-pypackage-success"></a>
 <a href="https://black.readthedocs.io/en/stable/"><img src="https://img.shields.io/badge/code%20style-black-000000"></a>

bin/make_python

@@ -8,7 +8,7 @@ if [ -n "${CI+x}" ]; then exit; fi
 
 pyenv_root=$(pyenv root)
 
-for python_version in 3.12.4 3.11.9 3.10.14 3.9.19 3.8.19; do
+for python_version in 3.12.7 3.11.10 3.10.15 3.9.20; do
     bin_dir=$pyenv_root/versions/$python_version/bin
     if [ ! -f "$bin_dir"/tox ]; then
         pyenv install --skip-existing "$python_version"

pyproject.toml

@@ -60,6 +60,10 @@ show_missing = true
 precision = 2
 fail_under = 100.00
 skip_covered = true
+exclude_also = [
+    # `if TYPE_CHECKING:` blocks are only executed while running mypy.
+    "if TYPE_CHECKING:",
+]
 
 [tool.isort]
 multi_line_output = 3

setup.cfg

@@ -16,7 +16,7 @@ classifiers =
 package_dir =
     = src
 packages = find:
-python_requires = >=3.8
+python_requires = >=3.9
 install_requires =
     pyramid
 

tox.ini

@@ -45,7 +45,7 @@ deps =
     lint,template: cookiecutter
     typecheck: mypy
 depends =
-    coverage: tests,py{311,310,39,38}-tests
+    coverage: tests,py{311,310,39}-tests
 commands =
     dev: {posargs:ipython --classic --no-banner --no-confirm-exit}
     format: black src tests bin