Ignore known error codes from the rostering services #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: lms/services/roster.py
Did you find this useful? React with a 👍 or 👎 |
marcospri
commented
Sep 4, 2024
lms/services/roster.py
Outdated
| # In cases for which we have different assignment IDs | ||
| and assignment.resource_link_id != assignment.lti_v13_resource_link_id | ||
| if err.response_body and ( | ||
| "Requested ResourceLink bound to unexpected external tool" # Canvas, unknown reason |
We'll tackle this individually as we gather more information are able to reproduce and fix them.
marcospri
force-pushed
the
ignore-known-roster-errors
branch
from
f78f8ad to
e4afdd9
Compare
acelaya
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll tackle this individually as we gather more information are able to reproduce and fix them.
See https://hypothes-is.slack.com/archives/C1MA4E9B9/p1725372178973579