Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model for LMSTerm #6971

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Model for LMSTerm #6971

merged 1 commit into from
Jan 29, 2025

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Jan 27, 2025

Migration over:

#6971

More context and testing instructions over:

#6969

@marcospri marcospri changed the base branch from main to store-term-info-migration January 27, 2025 15:58
@marcospri marcospri force-pushed the store-term-info-migration branch from 34111de to 5b29099 Compare January 28, 2025 14:22
@marcospri marcospri changed the title Store term info model Model for LMSTerm Jan 28, 2025
@marcospri marcospri force-pushed the store-term-info-model branch from e0d995d to 5da01a0 Compare January 28, 2025 14:23
@marcospri marcospri marked this pull request as ready for review January 28, 2025 14:34
@marcospri marcospri requested a review from mtomilov January 28, 2025 14:34
Copy link

@mtomilov mtomilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcospri marcospri force-pushed the store-term-info-migration branch 2 times, most recently from 570a2b8 to 41d6572 Compare January 29, 2025 13:07
@marcospri marcospri force-pushed the store-term-info-model branch from 5da01a0 to 88d64e4 Compare January 29, 2025 13:16
Base automatically changed from store-term-info-migration to main January 29, 2025 14:06
@marcospri marcospri force-pushed the store-term-info-model branch from 88d64e4 to 0e0768d Compare January 29, 2025 14:26
@marcospri marcospri merged commit 743733a into main Jan 29, 2025
9 checks passed
@marcospri marcospri deleted the store-term-info-model branch January 29, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants