Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python to 3.12.7 #1506

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade python to 3.12.7 #1506

wants to merge 1 commit into from

Conversation

mtomilov
Copy link

@mtomilov mtomilov commented Jan 6, 2025

No description provided.

@mtomilov mtomilov requested review from seanh and removed request for seanh January 6, 2025 15:52
@mtomilov mtomilov force-pushed the upgrade-python-to-3-12-7 branch 2 times, most recently from 1949f6c to 0d6e560 Compare January 6, 2025 17:43
@mtomilov mtomilov force-pushed the upgrade-python-to-3-12-7 branch from 0d6e560 to f6080d7 Compare January 6, 2025 18:08
@@ -8,6 +8,7 @@ filterwarnings = [
"ignore:^pkg_resources is deprecated as an API:DeprecationWarning:pyramid",
"ignore:^Deprecated call to .pkg_resources\\.declare_namespace\\('.*'\\).\\.:DeprecationWarning:pkg_resources",
"ignore:^'cgi' is deprecated and slated for removal in Python 3\\.13$:DeprecationWarning:webob",
"ignore:^datetime\\.datetime\\.utcnow\\(\\) is deprecated and scheduled for removal in a future version\\.:DeprecationWarning",
Copy link
Author

@mtomilov mtomilov Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one due to webob which sadly hasn't been updated 2021 where even the current main has the issue.

@@ -157,7 +157,7 @@ def parse_file_url(cls, public_url):

return data

def iter_file(self, file_id, resource_key=None) -> Iterator[ByteString]:
def iter_file(self, file_id, resource_key=None) -> Iterator[bytes]:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ByteString is now deprecated and we should be using plain bytes instead.

@mtomilov mtomilov requested a review from marcospri January 6, 2025 18:15
@mtomilov mtomilov self-assigned this Jan 6, 2025
@mtomilov mtomilov marked this pull request as draft January 7, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant