feat: cyclenext hist option #9055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truenya
force-pushed
the
8304
branch
15 times, most recently
from
f0765b7 to
c7bef97
Compare
Truenya
force-pushed
the
8304
branch
3 times, most recently
from
7361a6f to
4c2b880
Compare
Truenya
force-pushed
the
8304
branch
3 times, most recently
from
d7b7d6c to
39773eb
Compare
Truenya
force-pushed
the
8304
branch
3 times, most recently
from
9700555 to
2558af6
Compare
|
can you split the clang-tidy changes and feature? |
Truenya
force-pushed
the
8304
branch
2 times, most recently
from
04b2d48 to
f12406c
Compare
done |
vaxerski
reviewed
Jan 31, 2025
vaxerski
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Aded "hist"|"h" option to cyclenext dispatcher, with functionality described in #8304
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Some copy-paste code from cycleNext.
I couldn't generalize it because of type deducing problems. When one of the types is an iterator, I can't even specify it manually when calling
hyprwm/hyprland-wiki#954
Is it ready for merging, or does it need work?
ready for merging