src/config/ConfigWatcher.cpp: watch both symlinks and canonical paths #9219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fufexan
force-pushed
the
watch_symlinks
branch
from
661c842 to
1e8102b
Compare
bloxx12
approved these changes
Jan 29, 2025
|
why not just make it the default, and watch both the symlink itself and the pointed file? |
|
Sure, can do. |
|
@vaxerski how bout this |
fufexan
changed the title
vaxerski
reviewed
Jan 30, 2025
fufexan
force-pushed
the
watch_symlinks
branch
2 times, most recently
from
e37a093 to
42448ec
Compare
vaxerski
reviewed
Jan 31, 2025
fufexan
force-pushed
the
watch_symlinks
branch
from
42448ec to
388bf32
Compare
vaxerski
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Addsmisc:watch_symlinks, which makes inotify watch changes in the symlink, not in the file the symlink points to. This is especially useful on NixOS, and that's why it's disabled by default.Wiki PR: hyprwm/hyprland-wiki#957ConfigWatcher now watches both symlinks and regular files.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Should be good to go. Tested through
hyprctl keywordas well.Is it ready for merging, or does it need work?
Ready.