Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hyprbars] Improve (touch + button) functionality #265

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

caffeine01
Copy link
Contributor

@caffeine01 caffeine01 commented Jan 2, 2025

Task list:

  • Ability to customise the foreground colour of the icons
  • Ability to use the buttons with touch devices
  • Ability to move the window using the bar with touch devices
  • Further testing required for touch+cancel events (described below) vaxry fixed it lmao
  • Only render visible icons
  • Implement tablet/pen support, not looking very easy, will prob be done in another mr.

Note that as of 31/12/24 i no longer have access to a touch screen device in order to test touch functionality (it is being repaired).

(description below): There appears to be a bug where touching outside the main application (e.g. the border or the bar, i.e. A part of the window attached to the window but not the main application) causes touch down/click events to be sent to the application (?) which can open things like context menus. again, fixed by the man himself (vaxry)

@caffeine01
Copy link
Contributor Author

Added the automatic bullshit:

2025-01-02.12-48-29.mp4

@vaxerski
Copy link
Member

vaxerski commented Jan 2, 2025

if you need any touch testing I have a touch device

@caffeine01
Copy link
Contributor Author

if you need any touch testing I have a touch device

If you could test the context menu thing (occurs on most gnome apps, otherwise, xournalpp is a big one) and report the status of it (and maybe kinda help tell me where i need to be sending the cancel events).
I'm not fully convinced that sending cancel events will completely fix the issue, and i think this is an issue with how hl handles touch events mainly, but then again i dont know shit lol.

@vaxerski
Copy link
Member

vaxerski commented Jan 2, 2025

touch works now

@caffeine01
Copy link
Contributor Author

anything else to do?

@caffeine01
Copy link
Contributor Author

I reckon that pen support should also be added in this mr tbh, will take a look at that tomorrow probably.

@vaxerski
Copy link
Member

vaxerski commented Jan 3, 2025

fyi I don't have a pen to test.

@caffeine01
Copy link
Contributor Author

i have a few i can use to test

@caffeine01
Copy link
Contributor Author

@vaxerski ok either i am being retarded or ITablet needs to be created in hl.

@vaxerski
Copy link
Member

vaxerski commented Jan 4, 2025

it's an interface so you can't instantiate it

@caffeine01
Copy link
Contributor Author

caffeine01 commented Jan 5, 2025

it's an interface so you can't instantiate it

I am being retarded

@caffeine01
Copy link
Contributor Author

@vaxerski for some reason i cannot hook tablet tip events. for now though, binding one of the pen buttons (or the tip) to a mouse button with OTD works, however the cursor warp to position thing is a little buggy when doing that (i have a pen button bound to rmb):

2025-01-05.22-14-06.1.mp4

@vaxerski
Copy link
Member

vaxerski commented Jan 6, 2025

pens can be done later IMO, touch is more important.

@caffeine01
Copy link
Contributor Author

pens can be done later IMO, touch is more important.

I'm thinking the same, will remove from todolist

@caffeine01
Copy link
Contributor Author

Okay, with that this mr should be ready for review, marking as such.

@caffeine01 caffeine01 marked this pull request as ready for review January 6, 2025 17:32
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

hyprbars/main.cpp Show resolved Hide resolved
hyprbars/barDeco.cpp Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vaxerski vaxerski merged commit 948d70b into hyprwm:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants