-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hyprbars] Improve (touch + button) functionality #265
Conversation
Added the automatic bullshit: 2025-01-02.12-48-29.mp4 |
if you need any touch testing I have a touch device |
If you could test the context menu thing (occurs on most gnome apps, otherwise, xournalpp is a big one) and report the status of it (and maybe kinda help tell me where i need to be sending the cancel events). |
touch works now |
anything else to do? |
I reckon that pen support should also be added in this mr tbh, will take a look at that tomorrow probably. |
fyi I don't have a pen to test. |
i have a few i can use to test |
@vaxerski ok either i am being retarded or ITablet needs to be created in hl. |
it's an interface so you can't instantiate it |
I am being retarded |
@vaxerski for some reason i cannot hook tablet tip events. for now though, binding one of the pen buttons (or the tip) to a mouse button with OTD works, however the cursor warp to position thing is a little buggy when doing that (i have a pen button bound to rmb): 2025-01-05.22-14-06.1.mp4 |
pens can be done later IMO, touch is more important. |
I'm thinking the same, will remove from todolist |
Okay, with that this mr should be ready for review, marking as such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Task list:
Further testing required for touch+cancel events (described below)vaxry fixed it lmaoImplement tablet/pen support, not looking very easy, will prob be done in another mr.Note that as of 31/12/24 i no longer have access to a touch screen device in order to test touch functionality (it is being repaired).
(description below): There appears to be a bug where touching outside the main application (e.g. the border or the bar, i.e. A part of the window attached to the window but not the main application) causes touch down/click events to be sent to the application (?) which can open things like context menus.again, fixed by the man himself (vaxry)