-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support featureFlags anywhere #3771
Conversation
That worked but that feature flag is still mentioned at the bottom. Do you have any idea what causes all of the "attributes not found" that pops up after "feature flags" is fixed? It has been occurring on SystemUIGoogle.apk since Android 14, I believe.
|
It's mentioned at the bottom because it's passed to aapt2, as intended. |
Thanks!!!
…On Fri, Jan 17, 2025, 6:59 AM Igor Eisberg ***@***.***> wrote:
It's mentioned at the bottom because it's passed to aapt2, as intended.
The errors you're getting are unrelated to this issue.
The APK is in fact missing attributes and you'll have to add them yourself
if you want to rebuild the APK.
Likely caused by some nonsense in the AOSP build system.
—
Reply to this email directly, view it on GitHub
<#3771 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2JY6G6QI7Z2SILCPOSHSL2LD5BRAVCNFSM6AAAAABVLA2QOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJYGMYTIMJTHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Triple ticks in the future @Tulsadiver to save formatting - saves my eyes trying to read this. @IgorEisberg - I haven't messed with flags yet, so I'll take this down and mess with sample apk to wrap my head around this. In terms of those attr errors - last time I investigated that in 2023 it was a greedy build system removing the attributes and Apktool not being greedy enough to remove unused attrs. |
I apologize.... I tried but couldn't reduce the font size.
…On Fri, Jan 17, 2025, 7:11 AM Connor Tumbleson ***@***.***> wrote:
Triple ticks in the future @Tulsadiver <https://github.com/Tulsadiver> to
save formatting - saves my eyes trying to read this. @IgorEisberg
<https://github.com/IgorEisberg> - I haven't messed with flags yet, so
I'll take this down and mess with sample apk to wrap my head around this.
In terms of those attr errors - last time I investigated that in 2023
<#3129 (comment)>
it was a greedy build system removing the attributes and Apktool not being
greedy enough to remove unused attrs.
—
Reply to this email directly, view it on GitHub
<#3771 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD2JY6BHATHRVWADCHO2GFD2LD6RJAVCNFSM6AAAAABVLA2QOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJYGMZTQOBZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Wrap your head around what? Feature flags is a simple concept. You're overthinking it.
If they were unused that would make sense, but they are used in multiple layouts, which makes this a big question mark. |
Checked aapt2 source and how aapt2 responds to featureFlags specified in tags other than "permission". Apparently it's allowed to appear on any tag inside "manifest" as it's being pre-processed. An easy fix.
52cc3b7
to
02a87c5
Compare
If you can uncomment my test and confirm it works on this branch - should be good to go. 8886275 |
Tweaked your test for consistency with the other ApkInfo tests to not add even more redundancy. Works fine. Notes:
|
Checked aapt2 source and how aapt2 responds to featureFlags specified in tags other than "permission". Apparently it's allowed to appear on any tag inside "manifest" as it's being pre-processed. An easy fix.
Fixes #3768