-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/prevent zombie containers #53
base: main
Are you sure you want to change the base?
Conversation
A few remarks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
cli/src/execDocker/docker.js
Outdated
process.on('SIGINT', () => { | ||
abortController.abort(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registering the listener in the module scope and never cleaning it is problematic because it prevents SIGINT from stopping the process in the whole app.
This creates this bug:
I cannot cancel the command while a long async step is running (in the example TEE transformation step)
We need to register the SIGINT listener just before calling docker and clean it as soon as the docker interaction ends (successfully or with an error).
Co-authored-by: pjt <[email protected]>
Co-authored-by: pjt <[email protected]>
🔄 Scénarios gérés :
L'utilisateur peut choisir :
"Yes"
"No"