-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to actual BF font, now that DJI fixed G2 and newer #10620
base: master
Are you sure you want to change the base?
Conversation
osd maps have been updated where it makes sense
It would be worth adding to the release notes that Goggles V2 will have some issues. Also that Goggles 2 and above will need to be on the latest firmware. |
Hi @mmosca , I think you may have forgotten a few icons that can be used: LQ symbol:
Compass symbol:The betaflight speed icon also looks alittle bit like half of a compass:
There might be a few others as well. |
I agree with LQ. But using speed as compass is too wrong. |
INAV doesn't have a speed symbol anyway, might as well use it for something. Here's the code snippet:
|
That is a gauge. It would be fine for speed or RPM. But makes no sense for compass. Just using it for the sake of it is not the correct approach. Also, we should not be changing osd.c. These should be symbol changes only. |
I pretty much agree - LQ yes, and thanks for pointing that out! Speed for heading? Nah. Though I wouldn't be too upset if that was done. I can understand "may as well use it for something", but |
@@ -142,12 +142,13 @@ uint8_t getDJICharacter(uint8_t ch, uint8_t page) | |||
|
|||
case SYM_MAH: | |||
return DJI_SYM_MAH; | |||
|
|||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What line are you referring to? The efficiency ones are not available in the DJI/BF font.
The distance 0x&d and 0x7E are used in SYM_KM, SYN_MI
Not going to more extra code for this kind of stuff. |
No description provided.