-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydraulic Schema Releases #408
Conversation
...ics/PipeNetworkHydraulicAnalysis/Released/PipeNetworkHydraulicAnalysis.01.00.00.ecschema.xml
Outdated
Show resolved
Hide resolved
Domains/3-DisciplineOther/Hydraulics/Released/SewerHydraulicAnalysis.ecschema.01.00.00.xml
Outdated
Show resolved
Hide resolved
...plineOther/Hydraulics/PipeNetworkHydraulicAnalysis/PipeNetworkHydraulicAnalysis.ecschema.xml
Show resolved
Hide resolved
Domains/3-DisciplineOther/Hydraulics/SewerHydraulicAnalysis.ecschema.xml
Outdated
Show resolved
Hide resolved
Note that the schema filenames in their "Released" folders shall include their version numbers. More details at: https://github.com/iTwin/bis-schemas/blob/master/README.md#releasing-a-bis-schema |
@diegoalexdiaz - i triple checked the version are in the released file names - unless there is something I am missing but that file is there - at least in my PR - I tried to mimic your PR with the schema updates - but maybe I missed something? |
You got those filenames backwards... Your current filenames in Released folders: It should be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Can we get rid of tabs in these schemas and make the indentation consistent with other schemas (I think most schemas use 4 spaces for indentation)
Pry isn't quite right yet - but wanted to get in the mix to see what happens