Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydraulic Schema Releases #408

Merged
merged 15 commits into from
Dec 12, 2024
Merged

Hydraulic Schema Releases #408

merged 15 commits into from
Dec 12, 2024

Conversation

BenTWhite
Copy link
Contributor

Pry isn't quite right yet - but wanted to get in the mix to see what happens

@BenTWhite BenTWhite requested review from a team as code owners December 10, 2024 17:54
@BenTWhite BenTWhite requested a review from a team as a code owner December 10, 2024 18:42
@BenTWhite BenTWhite enabled auto-merge (squash) December 10, 2024 23:56
@diegoalexdiaz
Copy link
Contributor

Note that the schema filenames in their "Released" folders shall include their version numbers. More details at: https://github.com/iTwin/bis-schemas/blob/master/README.md#releasing-a-bis-schema

@BenTWhite
Copy link
Contributor Author

@diegoalexdiaz - i triple checked the version are in the released file names - unless there is something I am missing

I am getting this error:
image

but that file is there - at least in my PR - I tried to mimic your PR with the schema updates - but maybe I missed something?

@diegoalexdiaz
Copy link
Contributor

diegoalexdiaz commented Dec 11, 2024

You got those filenames backwards...

Your current filenames in Released folders:
[schema-name].ecschema.[schema-version].xml

It should be:
[schema-name].[schema-version].ecschema.xml

diegoalexdiaz
diegoalexdiaz previously approved these changes Dec 11, 2024
Copy link
Contributor

@karolis-zukauskas karolis-zukauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Can we get rid of tabs in these schemas and make the indentation consistent with other schemas (I think most schemas use 4 spaces for indentation)

@BenTWhite BenTWhite merged commit 3027bd4 into master Dec 12, 2024
18 checks passed
@BenTWhite BenTWhite deleted the hydraulic-release branch December 12, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants