website: Update slider documentation & demos #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
FlyersPh9
commented
Feb 7, 2023
•
FlyersPh9
commented
- Add slider demos for the different options.
- Update documentation, include adding hyperlinks to other mentioned components.
- Slider Website: Review documentation of each component #961
68 tasks
FlyersPh9
requested review from
a team,
gretanausedaite and
adamhock
and removed request for
a team
68 tasks
68 tasks
gretanausedaite
approved these changes
Mar 29, 2023
adamhock
reviewed
Mar 29, 2023
|
|
||
| Changes made with sliders should be immediate, allowing a user to make slider adjustments until finding their preference. This means a setting controlled by a slider should not require to be validated by clicking a button for the changes to be applied. | ||
|
|
||
| ## Variants |
There was a problem hiding this comment.
Are we adding any Usage section here? I'm not sure if all the components should have a Usage section even if it's empty?
There was a problem hiding this comment.
I've added a Usage section, moved some content around so that it makes a little more sense, and added more demos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.