Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Update Expandable Block documentation #1184

Merged
merged 16 commits into from
Apr 10, 2023

Conversation

adamhock
Copy link
Contributor

@adamhock adamhock commented Apr 4, 2023

Changes

Testing

N/A

Docs

N/A

@adamhock adamhock requested a review from a team as a code owner April 4, 2023 23:48
@adamhock adamhock requested review from a team, mayank99 and elephantcatdog and removed request for a team April 4, 2023 23:48

The child elements don’t reflect the column titles. They are expected to retain the same properties as the parent row (in the example below, the owner). It’s unnecessary to repeat the properties for the child items because of this, so do not include them in the expanded row area.
An expandable block could display status, an icon, or other helpful information at a glance right aligned within the block header.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old documentation site said the following:

An expandable block could display status, a total count, or other helpful information at a glance right aligned within the block header

I tried to find a way to display the count, but the count seems off-center so I removed it as an example

ExpandableBlockTotalCountBug

apps/website/src/pages/docs/expandableblock.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/expandableblock.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/expandableblock.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/expandableblock.mdx Outdated Show resolved Hide resolved
apps/website/src/pages/docs/expandableblock.mdx Outdated Show resolved Hide resolved
apps/website/src/examples/ExpandableBlock.form.tsx Outdated Show resolved Hide resolved
@adamhock adamhock self-assigned this Apr 5, 2023
@adamhock adamhock added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit c0c341e Apr 10, 2023
@adamhock adamhock deleted the adam/expandable-block-documentation branch April 10, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants