Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated header documentation. #1646
updated header documentation. #1646
Changes from 10 commits
0209846
3706861
8f543b3
02a5e8a
dbb483a
959db35
b697286
bb7e936
31b079f
714be06
3b52581
7ba2cb1
dc90bd0
b2c0871
561bbf9
d0d44b4
195c319
4fc86f2
ae8473c
ed689d4
cee2d83
c99cfad
5724ad7
304a34b
85f1bfd
0eb206f
648bb77
b53060b
460a7e8
bbea3e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are mentioning that
<HeaderButton>
can be made a link (above paragraph), would be good to show it in the example too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, was not sure about what link to add for
href
, so passing empty string. Is that okay?