Bump vite to ~5.4.14
#2312
Open
Bump vite to ~5.4.14
#2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
approved these changes
Jan 22, 2025
Comment on lines
90
to
103
| // https://github.com/vitejs/vite/pull/16051#issuecomment-2076616816 | ||
| function cssModuleSideEffectful() { | ||
| return { | ||
| name: 'css-module-side-effectful', | ||
| enforce: 'post', | ||
| transform(_, id) { | ||
| if (id.endsWith('.module.css')) { | ||
| return { | ||
| moduleSideEffects: 'no-treeshake', | ||
| }; | ||
| } | ||
| }, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Nice find. My only suggestion would be to inline this plugin in the config above, so that we get better types.
There was a problem hiding this comment.
Thanks! Sounds good, made it inline (fcd5592).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After PR TODO from #2256 (#2256 (comment)).
Fixes GHSA-vg6x-rcgg-rjx6. Closed #2409 in favor of this PR.
Bumps
vitefrom~5.1to~5.4.14.After the bump, the
styles.csswas not getting generated instyles.js/dist. Looks like it is because of vitejs/vite/#16051 from 5.2.0-beta.0.To fix it, I added the vite plugin suggested in vitejs/vite#16051 (comment). I had tried it when I had opened this PR too. However, it didn't work back then (which is why I had tried another fix which posed other problems; more info below). But since this vite plugin works now, I went ahead with this.
Old fix
To fix it, I renamed
styles.module.csstostyles.css. If there is a reason why the file has to be amodule.cssfile, then we'd have to import and use the styles somewhere, or something along these lines.One problem with using
styles.css, however, is that theiui-prefix is not there in the generated styles.css file because the css module part of the vite config file is not applied.Since I noticed multiple
viteversions, I also deduped it to use5.4.14(7ab18fb).Testing
buildscript is working in theitwinui-reactworkspacestyles.cssinpackages/itwinui-reactis unchanged.Docs
No changeset as
viteis used in dev workspaces or listed asdevDependenciesin the package workspaces (itwinui-react).