Light theme text selection opacity more consistent with OS #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
approved these changes
Jan 21, 2025
smmr-dn
approved these changes
Jan 21, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@mayank99 and I noticed this issue when discussing #2373. We felt felt that the text selection color in the light theme is too faint.
Thus, this PR increases the opacity of the text selection background from
0.2to0.25. This makes the light theme's text selection opacity more consistent with that of the OS.Testing
Thanks to @FlyersPh9 for the below screenshots:
Left: macOS default text selection
Right: current iTwinUI text selection
Left: macOS default text selection
Right: proposed new iTwinUI text selection
CSS visual tests passing locally but not on CI. Investigating the issue.Fixed by itself.Docs
Added two patch changesets: one for
@itwin/itwinui-reactand one for@itwin/itwinui-variables.