Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Alert): Improve test images #867

Merged
merged 5 commits into from
Dec 29, 2022
Merged

chore(Alert): Improve test images #867

merged 5 commits into from
Dec 29, 2022

Conversation

FlyersPh9
Copy link
Collaborator

  • Set viewport width of test images.
  • Removed <br />, using flex & gap instead.
  • Included padding so test images aren't right against the edge of the component.
  • Only testing 1 alert (negative) for hover & focus interactions.

Known issue for :focus outline color, bug filed #859.

@FlyersPh9 FlyersPh9 self-assigned this Dec 19, 2022
@FlyersPh9 FlyersPh9 requested a review from a team as a code owner December 19, 2022 22:17
@FlyersPh9 FlyersPh9 requested review from a team, gretanausedaite and adamhock and removed request for a team December 19, 2022 22:17
@FlyersPh9 FlyersPh9 linked an issue Dec 19, 2022 that may be closed by this pull request
49 tasks
mayank99 pushed a commit that referenced this pull request Dec 19, 2022
@FlyersPh9 FlyersPh9 merged commit 9770cae into main Dec 29, 2022
@FlyersPh9 FlyersPh9 deleted the jon/better-tests-alert branch December 29, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test image results
3 participants