Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Blockquote): Improve test images #871

Merged
merged 5 commits into from
Dec 29, 2022
Merged

Conversation

FlyersPh9
Copy link
Collaborator

  • Wrapped blockquote component in <section>.
  • Gave <section> padding so drop shadow is captured in the test images.
  • Set viewport width to keep test image narrow.

@FlyersPh9 FlyersPh9 self-assigned this Dec 20, 2022
@FlyersPh9 FlyersPh9 requested a review from a team as a code owner December 20, 2022 21:11
@FlyersPh9 FlyersPh9 requested review from a team, mayank99 and adamhock and removed request for a team December 20, 2022 21:11
@FlyersPh9 FlyersPh9 changed the title chore(Badge): Improve test images chore(Blockquote): Improve test images Dec 20, 2022
@FlyersPh9 FlyersPh9 requested review from elephantcatdog and removed request for mayank99 December 20, 2022 21:11
@FlyersPh9 FlyersPh9 linked an issue Dec 20, 2022 that may be closed by this pull request
49 tasks
@FlyersPh9 FlyersPh9 merged commit dc8d839 into main Dec 29, 2022
@FlyersPh9 FlyersPh9 deleted the jon/better-tests-blockquote branch December 29, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test image results
2 participants