-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit events when replaying external txns #417
Conversation
/azp run imodel-native |
Azure Pipelines successfully started running 1 pipeline(s). |
@swbsi or @tcobbs-bentley can you please submit a PR to fix or reduce the android build failures?
|
It looks like it's already set to use 4GB. We could of course bump that up, but I don't know if the error is because it's going over 4GB or if 4GB is not available. @swbsi, what do you think? Note that on my Mac, I have never had an Android build fail when Gradle is configured to use 4GB. |
I have also never had an issue at 4gb locally. Not sure if the error is really a system oom situation…maybe try a really large value locally (that you know will exceed physical+virtual on your box) and compare the resulting error? |
I'm not sure I'm willing to try doing that. What if we change it from 4GB to 3GB? |
@swbsi @tcobbs-bentley here is a better place to discuss and track. |
…ant to keep range index up to date after applying changes.
…odel-native into pmc/external-txn-events
/azp run imodel-native |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run imodel-native |
Azure Pipelines successfully started running 1 pipeline(s). |
@DanRod1999 @aruniverse is this supposed to show my linked PR branches? |
No. This only shows the initial branch that is pulled in by the pipeline as a repository resource. Your linked branch would be shown later inside the actual pipeline run on imodel-native-internal here: |
See iTwin/itwinjs-core#5867
itwinjs-core: https://github.com/iTwin/itwinjs-core/tree/pmc/external-txn-events
imodel-native-internal: https://github.com/iTwin/imodel-native-internal/tree/pmc/external-txn-events
TxnManager::ModelChanges seemed to assume changes can't be applied to a read-only briefcase. That's certainly not the case when the
watchForChanges
flag is enabled when opening the briefcase.As a result, it would fail to update a model's range index when its geometry changed.