Add custom error handling for the ITMGeolocationManager #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mobile-sdk/src/main/java/com/github/itwin/mobilesdk/ITMGeolocationManager.kt
Outdated
Show resolved
Hide resolved
mobile-sdk/src/main/java/com/github/itwin/mobilesdk/ITMGeolocationRequester.kt
Outdated
Show resolved
Hide resolved
mobile-sdk/src/main/java/com/github/itwin/mobilesdk/ITMGeolocationRequester.kt
Outdated
Show resolved
Hide resolved
mobile-sdk/src/main/java/com/github/itwin/mobilesdk/ITMGeolocationManager.kt
Outdated
Show resolved
Hide resolved
mobile-sdk/src/main/java/com/github/itwin/mobilesdk/ITMGeolocationRequester.kt
Outdated
Show resolved
Hide resolved
mobile-sdk/src/main/java/com/github/itwin/mobilesdk/ITMGeolocationRequester.kt
Outdated
Show resolved
Hide resolved
|
@cezaris13: Everything looks fine visually. I'm going to test it locally with the sample app to make sure nothing breaks, and assuming everything is OK I will then approve this PR. |
tcobbs-bentley
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In our app, instead of getting
ToastmessagePlease approve required permissions to show your location., we want to show alert, with the option to open the app settings:Solution
Added
customErrorHandlervariable, which can be set externally.If the variable is null, the
Toastis used.