Fix rcs (#82)

Co-authored-by: imodeljs-admin <[email protected]>
iTwin · Feb 27, 2024 · eade093 · eade093
1 parent 83779ea
commit eade093
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 11 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/python/pyproject.toml b/python/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "reality_apis"
-version = "1.0.6"
+version = "1.1.0"
 authors = [
   { name="Bentley Systems" },
 ]

diff --git a/python/reality_apis/RC/rcs_utils.py b/python/reality_apis/RC/rcs_utils.py
@@ -33,7 +33,7 @@ def __init__(self) -> None:
         self.inputs: RCJobSettings.Inputs = self.Inputs()
         self.outputs: RCJobSettings.Outputs = self.Outputs()
         self.engines: int = 0
-        self.merge: bool = True
+        self.merge: bool = False
 
     def to_json(self) -> tuple[dict, dict, dict]:
         """
@@ -99,7 +99,7 @@ def from_json(cls, settings_json: dict) -> ReturnValue[RCJobSettings]:
                 if output_dict["type"] == "OPC":
                     new_job_settings.outputs.OPC = []
                     new_job_settings.outputs.OPC.append(output_dict["id"])
-                if output_dict["type"] == "PNTS":
+                elif output_dict["type"] == "PNTS":
                     new_job_settings.outputs.PNTS = []
                     new_job_settings.outputs.PNTS.append(output_dict["id"])
                 else:

diff --git a/typescript/packages/reality-capture-analysis/CHANGELOG.json b/typescript/packages/reality-capture-analysis/CHANGELOG.json
@@ -1,6 +1,21 @@
 {
   "name": "@itwin/reality-capture-analysis",
   "entries": [
+    {
+      "date": "Tue, 27 Feb 2024 10:21:57 GMT",
+      "version": "1.0.1",
+      "tag": "@itwin/reality-capture-analysis_v1.0.1",
+      "comments": {
+        "patch": [
+          {
+            "author": "[email protected]",
+            "package": "@itwin/reality-capture-analysis",
+            "commit": "2024c640a60612d1317974327d2c6d777a459e42",
+            "comment": "Fix RCS Bug (Merge option default value was true instead of false)"
+          }
+        ]
+      }
+    },
     {
       "date": "Mon, 12 Feb 2024 17:17:32 GMT",
       "version": "1.0.0",

diff --git a/typescript/packages/reality-capture-analysis/CHANGELOG.md b/typescript/packages/reality-capture-analysis/CHANGELOG.md
@@ -1,9 +1,17 @@
 # Change Log - @itwin/reality-capture-analysis
 
-This log was last generated on Mon, 12 Feb 2024 17:17:32 GMT and should not be manually modified.
+This log was last generated on Tue, 27 Feb 2024 10:21:57 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 1.0.1
+
+Tue, 27 Feb 2024 10:21:57 GMT
+
+### Patches
+
+- Fix RCS Bug (Merge option default value was true instead of false) ([email protected])
+
 ## 1.0.0
 
 Mon, 12 Feb 2024 17:17:32 GMT

diff --git a/typescript/packages/reality-capture-analysis/package.json b/typescript/packages/reality-capture-analysis/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@itwin/reality-capture-analysis",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Reality Analysis sdk to run analysis jobs",
   "main": "lib/cjs/index.js",
   "module": "lib/esm/index.js",

diff --git a/typescript/packages/reality-capture-conversion/src/Utils.ts b/typescript/packages/reality-capture-conversion/src/Utils.ts
@@ -87,7 +87,7 @@ class RCOptions {
         /** If true, all the input files from multiple containers will be merged into one output file. Else output file will be created per input file. 
          * @type { boolean }
          */
-        this.merge = true;
+        this.merge = false;
     }
 }