-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass enableVirtualization
flag to itwinui <Tree />
#1133
Conversation
@saskliutas, what do you think about this? IMO, our renderer should always use virtualization and the prop should not be available for consumers of our component. |
I think it makes sense to allow consumer to decide whether virtualization is used or not. This |
Sounds good. Should |
change/@itwin-tree-widget-react-424293ad-271d-412a-8226-14565b130d88.json
Outdated
Show resolved
Hide resolved
I this this could be solved in a separate PR. We should probably also review if there are more props that are exposed but not propagated down to the base iTwinUI |
Co-authored-by: Saulius Skliutas <[email protected]>
Filed a followup issue: #1137 |
Closes #1132