Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitigate ws and braces vulnerabilities #320

Closed
wants to merge 4 commits into from
Closed

mitigate ws and braces vulnerabilities #320

wants to merge 4 commits into from

Conversation

ben-polinsky
Copy link
Contributor

Mitigates GHSA-3h5v-q93c-6h6q, GHSA-grv7-fg5c-xmjg

Unfortunately, pnpm global overrides seems to be the only way to go for braces which is a deep transient dependency off react-scripts.

aruniverse
aruniverse reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rush update --full didnt work?

rush.json Show resolved Hide resolved
@ben-polinsky
Copy link
Contributor Author

rush update --full didnt work?

Nope couldn't get braces updated...

@aruniverse
Copy link
Member

rush update --full didnt work?

Nope couldn't get braces updated...

Do we still need to add the ws dep in the test apps?

@ben-polinsky
Copy link
Contributor Author

rush update --full didnt work?

Nope couldn't get braces updated...

Do we still need to add the ws dep in the test apps?

nope - makes sense

@ben-polinsky
Copy link
Contributor Author

ben-polinsky commented Jul 8, 2024 •
edited
Loading

@jasdom since I am running into issues which cross over into #319, maybe you can pick my changes here relating to the failed audit I was attempting to resolve

@jasdom
Copy link
Contributor

jasdom commented Jul 8, 2024

@jasdom since I am running into issues which cross over into #319, maybe you can pick my changes here relating to the failed audit I was attempting to resolve

Sure, I was working on these exact changes to resolve the vulnerabilities myself so I will include them in my PR.

@aruniverse aruniverse closed this Oct 10, 2024
@aruniverse aruniverse deleted the GHSA-3h5v-q93c-6h6q branch January 8, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruniverse aruniverse aruniverse left review comments

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben-polinsky @aruniverse @jasdom