fix(MobilityDataValidation): slow on large gtfs files #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
philip-cline
approved these changes
Apr 13, 2023
| // TODO: base this on the file being completely saved rather than a fixed amount of time. | ||
| Thread.sleep(5000); | ||
| // 5 seconds + ~1 second per 10mb | ||
| Thread.sleep(5000 + (this.fileSize / 10000)); |
There was a problem hiding this comment.
What unit is this.fileSize? According to the code, it is set with [newGtfs]File.length() which is in bytes.
There was a problem hiding this comment.
I'm not sure, but this does fix things
There was a problem hiding this comment.
@miles-grant-ibigroup Can you fix the comment so it corresponds to the code?
There was a problem hiding this comment.
Did I get the decimal math right in 0ebf222?
There was a problem hiding this comment.
I'm sorry, the initial comment was correct, juggling with the units was confusing (10,000,000 / 10,000 = 1000).
binh-dam-ibigroup
approved these changes
May 24, 2023
This reverts commit 0ebf222.
|
Not sure why it says closed instead of merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
The MobilityData validator takes a while between finishing and saving results. There is no way to check when this process completes using their api. The solution is to do a wait, currently 5 seconds. However, on large feeds this is not enough. The solution is to adjust the wait depending on file size.
Closes #524
Looking to try this fix on as wide a variety of systems as possible to make sure the values are correct