address pr feedback

ibi-group · Oct 18, 2023 · 97d9167 · 97d9167
1 parent 533991e
commit 97d9167
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/manager/components/ProjectSettingsForm.js b/lib/manager/components/ProjectSettingsForm.js
@@ -185,6 +185,8 @@ export default class ProjectSettingsForm extends Component<Props, State> {
     this.setState(update(this.state, {model: {$merge: {defaultTimeZone}}}))
   }
 
+  // TODO: shared type
+  // https://github.com/ibi-group/datatools-ui/pull/986#discussion_r1362271761
   _onChangeTextInput = ({target}: {target: {name?: string, value: string}}) => {
     const {name, value} = target
     if (!name) return
@@ -340,11 +342,11 @@ export default class ProjectSettingsForm extends Component<Props, State> {
 
                 see: https://github.com/ibi-group/datatools-ui/pull/977#discussion_r1288916749 */}
                 <CustomCSVForm
-                  name={'sharedStopsConfig'}
                   csvData={model.sharedStopsConfig || ''}
                   hideSaveButton
-                  onChangeCsvData={(e) => this._onChangeTextInput(e)}
-                  onSaveCsvData={() => { alert('save') }}
+                  name={'sharedStopsConfig'}
+                  onChangeCsvData={this._onChangeTextInput}
+                  onSaveCsvData={() => {}}
                   placeholder={`stop_group_id,feed_id,stop_id,is_primary\n1,1,29240,1\n1,3,4705,0`}
                 />
               </FormGroup>

diff --git a/lib/manager/components/transform/CustomCSVForm.js b/lib/manager/components/transform/CustomCSVForm.js
@@ -75,9 +75,11 @@ const CustomCSVForm = (props: Props) => {
       </label>
       <div style={{marginBottom: '10px'}}>
         <input
-          type='file'
           name='file'
+          type='file'
           onChange={(e) => {
+            // TODO: use useCallback
+            // https://github.com/ibi-group/datatools-ui/pull/986#discussion_r1362276889
             if (e.target && e.target.files.length > 0) {
               onChangeCsvData({target: {name, value: messages('uploading')}})
               const reader = new FileReader()