Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TripSeriesModal States #1002

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Refactor TripSeriesModal States #1002

merged 6 commits into from
Dec 8, 2023

Conversation

AdrianaCeric
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • All tests and CI builds passing

Description

There are a lot of state variables in TripSeriesModal. This PR combines them in one state object

philip-cline
philip-cline suggested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to change

lib/editor/components/timetable/TripSeriesModal.js Outdated Show resolved Hide resolved
lib/editor/components/timetable/TripSeriesModal.js Show resolved Hide resolved
philip-cline
philip-cline approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM for cleaning this up!

miles-grant-ibigroup
miles-grant-ibigroup requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup! Just a few quick notes

lib/editor/components/timetable/TripSeriesModal.js Outdated Show resolved Hide resolved
lib/editor/components/timetable/TripSeriesModal.js Outdated Show resolved Hide resolved
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Wonderful cleanup!

@AdrianaCeric AdrianaCeric merged commit 69dba66 into dev Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-cline philip-cline philip-cline approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@AdrianaCeric AdrianaCeric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianaCeric @philip-cline @miles-grant-ibigroup