Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Timetable Pasting #1003

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Fix Timetable Pasting #1003

merged 4 commits into from
Dec 5, 2023

Conversation

philip-cline
Copy link
Contributor

@philip-cline philip-cline commented Nov 23, 2023

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

  • Enhances data handling when pasting content from the clipboard, such as CSV data, into TEXT type timetable cells (e.g., Trip ID, Trip Headsign). Previously, the data was returned as seconds, which an issue
    image
  • Improves the handling of carriage return characters that may appear when pasting data from Excel so parseCellValue can parse the correct string inTIMETABLE_FORMATS
  • Checks if the parsed value is valid and keeps the original value of the timetable cell instead of returning 00:00:00 for:
    • pasted CSV
    • inputted data in individual cells

Copy link
Contributor

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @philip-cline @miles-grant-ibigroup

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of logic, good work though!

@philip-cline
Copy link
Contributor Author

I am mad to be merging this. but it works.

@philip-cline philip-cline merged commit 42f00ee into dev Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants