Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Stops Support File Upload #986

Merged
merged 14 commits into from
Oct 18, 2023
Merged

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented Sep 7, 2023

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

This PR expands upon the shared stops PR to add support for uploading a file to the textbook. Also adds support for uploading a file into the transformations form 🥳

@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review September 8, 2023 16:35
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things to debate/change

i18n/english.yml Show resolved Hide resolved
lib/manager/components/ProjectSettingsForm.js Show resolved Hide resolved
lib/manager/components/ProjectSettingsForm.js Show resolved Hide resolved
@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Oct 6, 2023
@miles-grant-ibigroup
Copy link
Contributor Author

Let me know what you think about this fix @philip-cline

@philip-cline
Copy link
Contributor

philip-cline commented Oct 6, 2023

@miles-grant-ibigroup I'm still getting a page unresponsive error since we're loading the file directly which rly isn't great. We could do something or transformations like just pass the file to the backend and have it parse it to avoid that unresponsive error. However since this PR is focused on Shared Stops and the specific use case that would cause the lag in a transformation has a method which is fine rn, I'm fine with separating that into a later PR if you'd like

Lmk what you think @miles-grant-ibigroup

@miles-grant-ibigroup
Copy link
Contributor Author

Just to be clear, was this an issue before this PR?

@philip-cline
Copy link
Contributor

Good point, yes in a bit of a different way but yes

@miles-grant-ibigroup miles-grant-ibigroup removed their assignment Oct 13, 2023
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can resolve the issues with large file csv uploads in a different PR

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see a few cleanup suggestions. We can discuss about a separate removal of the keyboard listener in ProjectSettingsForm.

lib/manager/components/ProjectSettingsForm.js Show resolved Hide resolved
lib/manager/components/ProjectSettingsForm.js Show resolved Hide resolved
lib/manager/components/ProjectSettingsForm.js Outdated Show resolved Hide resolved
lib/manager/components/ProjectSettingsForm.js Outdated Show resolved Hide resolved
lib/manager/components/ProjectSettingsForm.js Show resolved Hide resolved
@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Oct 18, 2023
@miles-grant-ibigroup miles-grant-ibigroup merged commit 5ef96bd into dev Oct 18, 2023
@miles-grant-ibigroup miles-grant-ibigroup deleted the shared-stops-csv-upload branch October 18, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants