-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Stops Support File Upload #986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things to debate/change
Let me know what you think about this fix @philip-cline |
@miles-grant-ibigroup I'm still getting a page unresponsive error since we're loading the file directly which rly isn't great. We could do something or transformations like just pass the file to the backend and have it parse it to avoid that unresponsive error. However since this PR is focused on Shared Stops and the specific use case that would cause the lag in a transformation has a method which is fine rn, I'm fine with separating that into a later PR if you'd like Lmk what you think @miles-grant-ibigroup |
Just to be clear, was this an issue before this PR? |
Good point, yes in a bit of a different way but yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can resolve the issues with large file csv uploads in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see a few cleanup suggestions. We can discuss about a separate removal of the keyboard listener in ProjectSettingsForm
.
Checklist
dev
before they can be merged tomaster
)Description
This PR expands upon the shared stops PR to add support for uploading a file to the textbook. Also adds support for uploading a file into the transformations form 🥳