Fix RouteLayout Pagination #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
AdrianaCeric
approved these changes
Oct 23, 2023
| <div> | ||
| <Pagination | ||
| bsSize='small' | ||
| // onSelect={(e) => console.log('yoyo')} |
| <Pagination.Item | ||
| active={pageNum === activePage} | ||
| key={pageNum} | ||
| onClick={(e) => this._onPaginationSelect(+e.target.text)} |
There was a problem hiding this comment.
Suggested change
| onClick={(e) => this._onPaginationSelect(+e.target.text)} | |
| onClick={() => this._onPaginationSelect(pageNum)} |
I'm not too familiar with what +e.target.text does. Maybe this is more readable?
There was a problem hiding this comment.
e is just a general shorthand for the event in the event handler, which in this case is the onClick event that happens when you click on the pagination menu. We need to use that to retrieve the page number that is clicked, otherwise pageNum would pass the current page number. e.target.text is just how we can access the text (page number) that was clicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Fix the pagination in the RouteLayout component, which has been the topic of some recent complaints.