Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ExpandDateTime convenience (datetime components) #20

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: ExpandDateTime convenience (datetime components) #20

merged 2 commits into from
Mar 6, 2024

Conversation

IndexSeek
Copy link
Member

Closes #14, this is a recreation of #15, which I will close tomorrow.

The test has been updated as well. This is how I have been using it to try this out, similar to the previous PR.

from ibis.interactive import *
import ibisml as ml

con = ibis.duckdb.connect()

t = con.sql("select get_current_timestamp() AS datetime")
step = ml.ExpandDateTime("datetime")
transform = step.fit(t, ml.core.Metadata())
res = transform.transform(t)
res

When no literal values are passed to the components on the return, all columns except second and millisecond are chosen.

@IndexSeek IndexSeek changed the title feat: ExpandDateTime convenience (single column) feat: ExpandDateTime convenience (datetime components) Feb 25, 2024
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcrist jcrist merged commit 54e7c16 into ibis-project:main Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExpandDate + ExpandTime = ExpandDateTime
3 participants