fix(duckdb): ensure that duckdb columns argument to read_csv accepts …

…duckdb syntax not ibis syntax
ibis-project · Jan 21, 2025 · ba8b94a · ba8b94a
1 parent 671cc88
commit ba8b94a
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/ibis/backends/duckdb/__init__.py b/ibis/backends/duckdb/__init__.py
@@ -667,14 +667,17 @@ def read_csv(
         def make_struct_argument(obj: Mapping[str, str | dt.DataType]) -> sge.Struct:
             expressions = []
             geospatial = False
-            type_mapper = self.compiler.type_mapper
+            dialect = self.compiler.dialect
 
             for name, typ in obj.items():
-                typ = dt.dtype(typ)
-                geospatial |= typ.is_geospatial()
-                sgtype = type_mapper.from_ibis(typ)
+                sgtype = sg.parse_one(typ, read=dialect, into=sge.DataType)
+                geospatial |= sgtype.this in (
+                    sge.DataType.Type.GEOGRAPHY,
+                    sge.DataType.Type.GEOMETRY,
+                )
                 prop = sge.PropertyEQ(
-                    this=sge.to_identifier(name), expression=sge.convert(sgtype)
+                    this=sge.to_identifier(name),
+                    expression=sge.convert(sgtype.sql(dialect)),
                 )
                 expressions.append(prop)