Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pyspark): simplify clean up by making __del__ a no-op in the spark case #10708

Closed
wants to merge 3 commits into from
Closed

test(pyspark): simplify clean up by making __del__ a no-op in the spark case #10708

wants to merge 3 commits into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 22, 2025

This should clear up the flaky spark-remote tests in CI.

@cpcloud cpcloud added this to the 10.0 milestone Jan 22, 2025
@cpcloud cpcloud added tests Issues or PRs related to tests pyspark The Apache PySpark backend labels Jan 22, 2025
@cpcloud cpcloud force-pushed the fix-pyspark-remote-test-cleanup branch from 4a091ed to 07d13cd Compare January 23, 2025 16:42
@github-actions github-actions bot added postgres The PostgreSQL backend sqlite The SQLite backend clickhouse The ClickHouse backend mysql The MySQL backend datafusion The Apache DataFusion backend duckdb The DuckDB backend polars The polars backend snowflake The Snowflake backend mssql The Microsoft SQL Server backend trino The Trino backend oracle The Oracle backend flink Issues or PRs related to Flink risingwave The RisingWave backend labels Jan 23, 2025
@cpcloud cpcloud changed the title test(pyspark): simplify clean up by making __del__ a no-op in the SPARK_REMOTE case test(pyspark): simplify clean up by making __del__ a no-op in the spark case Jan 23, 2025
@cpcloud cpcloud closed this Jan 24, 2025
@cpcloud cpcloud deleted the fix-pyspark-remote-test-cleanup branch January 24, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clickhouse The ClickHouse backend datafusion The Apache DataFusion backend duckdb The DuckDB backend flink Issues or PRs related to Flink mssql The Microsoft SQL Server backend mysql The MySQL backend oracle The Oracle backend polars The polars backend postgres The PostgreSQL backend pyspark The Apache PySpark backend risingwave The RisingWave backend snowflake The Snowflake backend sqlite The SQLite backend tests Issues or PRs related to tests trino The Trino backend
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@cpcloud